Skip to content

Fixed invalid loop length for probe baking (case 1289680) #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2020
Merged

Fixed invalid loop length for probe baking (case 1289680) #2830

merged 3 commits into from
Dec 15, 2020

Conversation

fredericv-unity3d
Copy link
Contributor

Purpose of this PR

Fixes case 1289680.

A loop was using an invalid counter causing a write to an invalid address in the stack.

Fixed: use the appropriate counter for the loop.

Testing status

Manual test on the provided case scene (Sponza)

  1. Bake the lighting data
  2. Clear the lighting data
  3. Bake the lighting data

Observes the bake does complete without error and the probes are baked appropriately.

Comments to reviewers

QA:

  • Can you do the manual test on another computer to make sure it is consistent

@fredericv-unity3d
Fixed invalid loop length for probe baking (case 1289680)
5753a6b 
# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
TomasKiniulis
TomasKiniulis approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked repro project with steps provided and template, not encountering the exception anymore

@sebastienlagarde sebastienlagarde marked this pull request as ready for review December 15, 2020 13:23
@sebastienlagarde sebastienlagarde merged commit 53096ec into hd/bugfix Dec 15, 2020
@sebastienlagarde sebastienlagarde deleted the hd/bugfix_case_1289680 branch December 15, 2020 13:24
@sebastienlagarde sebastienlagarde mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@JulienIgnace-Unity JulienIgnace-Unity JulienIgnace-Unity approved these changes

@TomasKiniulis TomasKiniulis TomasKiniulis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-10.x HDRP SRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fredericv-unity3d @sebastienlagarde @JulienIgnace-Unity @TomasKiniulis