Init scene camera debug framesettings #2931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Dec 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Tentative fix for https://fogbugz.unity3d.com/f/cases/1292238/
The bug is difficult to repro so I am not sure the fix actually works but it seems a reasonable attempt.
When the bug happens, the framesettings of the scene view camera are all set to false, and it looks like this MinimalHistoryContainer is the only place where framesettings are set to zero.
Same as #2614
Testing status
Can't reproduce the bug but can't before the fix also so...