Skip to content

Fixed shader graph not supporting indirectdxr multibounce (case 1294694) #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2020
Merged

Fixed shader graph not supporting indirectdxr multibounce (case 1294694) #2933

merged 2 commits into from
Dec 17, 2020

Conversation

anisunity
Copy link
Contributor

The keyword was missing from shader graphs which made it is malfunction.
https://fogbugz.unity3d.com/f/cases/1294694/

Testing status
Reimported the shader and the multibounce works properly now.

@anisunity anisunity self-assigned this Dec 17, 2020
@sebastienlagarde sebastienlagarde marked this pull request as ready for review December 17, 2020 16:01
remi-chapelain
remi-chapelain approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly tested all HDRP material in SG and "Regular" to be sure.
Made me think that it would be a good idea to test this behavior in at least one of our test scene.
I'll try and modify one to integrate this when I have time.

@sebastienlagarde sebastienlagarde merged commit c4ea601 into hd/bugfix Dec 17, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-sg-multibounce branch December 17, 2020 18:41
@sebastienlagarde sebastienlagarde mentioned this pull request Dec 18, 2020
Merged
@remi-chapelain remi-chapelain mentioned this pull request Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alelievr alelievr alelievr approved these changes

@remi-chapelain remi-chapelain remi-chapelain approved these changes

+1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anisunity anisunity

Labels

backported-10.x backported-2021.1 dxr HDRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anisunity @alelievr @sebastienlagarde @remi-chapelain