Skip to content

Fix FreeCamera speed boost controls #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Fix FreeCamera speed boost controls #2967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Fixed
- Fixed ACES tonemaping for Nintendo Switch by forcing some shader color conversion functions to full float precision.
- Fixed a bug in FreeCamera which would only provide a speed boost for the first frame when pressing the Shfit key.

## [10.2.0] - 2020-10-19

Expand Down
8 changes: 3 additions & 5 deletions com.unity.render-pipelines.core/Runtime/Camera/FreeCamera.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ void UpdateInputs()
inputRotateAxisX += (Input.GetAxis(kRightStickX) * m_LookSpeedController * Time.deltaTime);
inputRotateAxisY += (Input.GetAxis(kRightStickY) * m_LookSpeedController * Time.deltaTime);

leftShift = Input.GetKeyDown(KeyCode.LeftShift);
leftShift = Input.GetKey(KeyCode.LeftShift);
fire1 = Input.GetAxis("Fire1") > 0.0f;

inputChangeSpeed = Input.GetAxis(kSpeedAxis);
Expand Down Expand Up @@ -192,10 +192,8 @@ void Update()
transform.localRotation = Quaternion.Euler(newRotationX, newRotationY, transform.localEulerAngles.z);

float moveSpeed = Time.deltaTime * m_MoveSpeed;
if (leftShiftBoost)
moveSpeed *= leftShift ? m_Turbo : 1.0f;
else
moveSpeed *= fire1 ? m_Turbo : 1.0f;
if (fire1 || leftShiftBoost && leftShift)
moveSpeed *= m_Turbo;
transform.position += transform.forward * moveSpeed * inputVertical;
transform.position += transform.right * moveSpeed * inputHorizontal;
transform.position += Vector3.up * moveSpeed * inputYAxis;
Expand Down