Fixed the condition on temporal accumulation in the reflection denoiser (case 1303504). #3027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (case 1303504).
remi-chapelain
approved these changes
Jan 8, 2021
sebastienlagarde
approved these changes
Jan 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a recent changes that depending on the smoothness of a surface changes the strategy of rtr denoising, the conditions to reject history was wrong. this PR fixes it.
https://fogbugz.unity3d.com/f/cases/1303504/
Testing status
Tried to repro the issue on the dataset after the fix, can't repro.
DXR tests are green locally.