Skip to content

Conversation

fabien-unity
Copy link
Collaborator


Purpose of this PR

  • refactor XR tests to be able to use MockHMD and the full XR SDK path
  • disable some tests until further investigation

Testing status

Yamato run is similar to master (mac is failing).


Comments to reviewers

There's a lot a files but it's mostly boilerplate and Yamato configuration

@fabien-unity fabien-unity marked this pull request as ready for review January 11, 2021 15:30
@fabien-unity fabien-unity requested a review from a team as a code owner January 11, 2021 15:30
Copy link
Contributor

@DennisDeRykeUnity DennisDeRykeUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve.

For this PR I am only comparing master versus the dev branch for Nightly HDRP on Yamato, because the code changes are isolated to:

  • com.unity.render-pipelines.high-definition
  • com.unity.testing.hdrp
  • HDRP-based test projects
  • HDRP-related Yamato configuration

Some observations:

  1. Nightly HDRP contains the same number of pipelines for both dev branch and master; both contain six XR pipelines.

  2. In Nightly HDRP for master HDRP_DXR on Win_DX12_playmode_XR failed due to a single inconclusive test, HDRP_GraphicTestRunner.5006_PathTracing_DoF, which is not present in the dev branch results.

  3. For the dev branch all XR pipelines in Nightly HDRP passed.

  4. In Nightly HDRP the only failed pipeline for the dev branch was HDRP on OSX_Metal_playmode. This pipeline failed on both master and the dev branch with 26 failed tests.

@sebastienlagarde sebastienlagarde marked this pull request as draft January 13, 2021 18:59
@sebastienlagarde sebastienlagarde marked this pull request as ready for review January 13, 2021 19:04
@sebastienlagarde sebastienlagarde merged commit 1a0c839 into master Jan 13, 2021
@sebastienlagarde sebastienlagarde deleted the tests/xr/convert-to-mockhmd-2 branch January 13, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants