-
Notifications
You must be signed in to change notification settings - Fork 855
Convert HDRP tests to use MockHMD for XR #3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve.
For this PR I am only comparing master versus the dev branch for Nightly HDRP on Yamato, because the code changes are isolated to:
- com.unity.render-pipelines.high-definition
- com.unity.testing.hdrp
- HDRP-based test projects
- HDRP-related Yamato configuration
Some observations:
-
Nightly HDRP contains the same number of pipelines for both dev branch and master; both contain six XR pipelines.
-
In Nightly HDRP for master HDRP_DXR on Win_DX12_playmode_XR failed due to a single inconclusive test, HDRP_GraphicTestRunner.5006_PathTracing_DoF, which is not present in the dev branch results.
-
For the dev branch all XR pipelines in Nightly HDRP passed.
-
In Nightly HDRP the only failed pipeline for the dev branch was HDRP on OSX_Metal_playmode. This pipeline failed on both master and the dev branch with 26 failed tests.
Purpose of this PR
Testing status
Yamato run is similar to master (mac is failing).
Comments to reviewers
There's a lot a files but it's mostly boilerplate and Yamato configuration