[HDRP] Fix error in Depth Of Field near radius blur calculation #3131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return parameters; | ||
| } | ||
|
|
||
| static void GetDoResolutionScale(in DepthOfFieldParameters dofParameters, out float scale, out float resolutionScale) |
There was a problem hiding this comment.
I assume DoF here.
There was a problem hiding this comment.
Yeah, I already fixed it :)
|
LGTM |
FrancescoC-unity
approved these changes
Jan 15, 2021
sebastienlagarde
approved these changes
Jan 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1306228/
There was an error depending on the value of near max radius.
The near max radius controls the number of dilation passes. The problem was that the computation of passes during RG execution was taking resolution scale into account, but not during the RG pass setup.
Testing status