[2021.2] Particle Shaders: Adding Depth & Depth Normals passes #3141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellioman
changed the title
ghost
reviewed
Jan 18, 2021
com.unity.render-pipelines.universal/Shaders/Particles/ParticlesDepthNormalsPass.hlsl
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jan 18, 2021
com.unity.render-pipelines.universal/Shaders/Particles/ParticlesDepthNormalsPass.hlsl
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jan 18, 2021
com.unity.render-pipelines.universal/Shaders/Particles/ParticlesDepthOnlyPass.hlsl
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jan 18, 2021
com.unity.render-pipelines.universal/Shaders/Particles/ParticlesSimpleLitInput.hlsl
Show resolved
Hide resolved
ghost
approved these changes
Jan 18, 2021
simon-engelbrecht-soerensen
requested review from
a team and
simon-engelbrecht-soerensen
and removed request for
a team and
simon-engelbrecht-soerensen
|
@richardkettlewell Good points! I've added those checks to avoid unnecessary interpolators. |
Nice, looks good! |
lukaschod
reviewed
Jan 19, 2021
com.unity.render-pipelines.universal/Shaders/Particles/ParticlesUnlit.shader
Outdated
Show resolved
Hide resolved
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
lukaschod
approved these changes
Jan 20, 2021
erikabar
approved these changes
Feb 1, 2021
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Particles currently do not contribute to Depth or DepthNormal textures. This causes an issue with SSAO when the
After Opaqueoption is enabled as it makes them look transparent.This PR adds Depth and DepthNormals passes to particle shaders. I had to add a
#define _BumpScale 1.0to the input hlsl files for simplelit and unlit in order to be able to callSampleNormalTS(...)using the same fragment shader for all particles.A test scene will be added to the URP Graphics Test project in a followup PR.
QA
What has been tested
What needs testing
Yamato
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Ffeature%252Fparticles-depth-and-normals