Fix XR depth copy #3200
Merged
Fix XR depth copy #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien-unity
requested review from
JulienIgnace-Unity,
ryanhy-unity and
sebastienlagarde
...nity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs
Show resolved
Hide resolved
JulienIgnace-Unity
approved these changes
Jan 21, 2021
sebastienlagarde
approved these changes
Jan 21, 2021
|
@fabien-unity is there a way to produce a test for this so we don't break it again? |
Yes but it's not trivial. I've added it to our roadmap! |
|
Did a quick check with a new project (mock and Oculus) and didn't see any issues with this PR. Seeing as Fabien has run through the bug scenario with Varyo and verified the fix as well I think this looks good from my point of view. |
ryanhy-unity
approved these changes
Jan 21, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 21, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Make sure the depth buffer is properly copied for each views so that devices like Oculus or Varjo can make use of them for better reprojection or Mixed Reality usage.
Testing status
Locally tested with HDRP template on Win10 (d3d11) with the Varjo Analytics debug tool as described in the bug (https://fogbugz.unity3d.com/f/cases/1286908/).
Comments to reviewers
@JulienIgnace-Unity : can you double-check the depth copy code/shader for non XR usage ? Maybe add a QA member to this PR to run some more tests ?