Skip to content

Conversation

sophiaaar
Copy link
Contributor

@sophiaaar sophiaaar commented Jan 21, 2021

Purpose of this PR

Enable cache server for the XR jobs


Testing status


Comments to reviewers

Failures appear to match master, and I accidentally kicked off some jobs that havent been run on master too

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only missing --testfilter="VFX.Test
And also, we could use cache server in vfx_urp.metafile (not sure it's relevant)

Copy link
Contributor

@theopnv theopnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for what @PaulDemeulenaere already said about the filtering for vfx.
Thanks!

@sophiaaar sophiaaar marked this pull request as ready for review January 21, 2021 12:12
@sophiaaar sophiaaar requested a review from a team as a code owner January 21, 2021 12:12
@sophiaaar sophiaaar merged commit d22d595 into master Jan 21, 2021
@sophiaaar sophiaaar deleted the yamato/xr-cache-server branch January 21, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants