Skip to content

Makes sure quaternion is normalized and valid before converting to ma… #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2020
Merged

Makes sure quaternion is normalized and valid before converting to ma… #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c75e6c3
Makes sure quaternion is normalized and valid before converting to ma…
eturquin Apr 29, 2020
60e65b5
Updated Changelo.
eturquin Apr 29, 2020
a49086f
Revert "Updated Changelo."
sebastienlagarde May 6, 2020
42a1f75
Update CHANGELOG.md
sebastienlagarde May 6, 2020
e353d99
Merge branch 'HDRP/staging' into HDRP/fix_quaternion_error
sebastienlagarde May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed thin refraction mode not working properly.
- Fixed assert on tests caused by probe culling results being requested when culling did not happen. (case 1246169)
- Fixed over consumption of GPU memory by the Physically Based Sky.
- Fixed an invalid rotation in Planar Reflection Probe editor display, that was causing an error message (case 1182022)

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
2 changes: 1 addition & 1 deletion ...ender-pipelines.high-definition/Editor/Lighting/Reflection/PlanarReflectionProbeEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ static void DrawCapturePositionGizmo(PlanarReflectionProbe probe)
var mirrorPositionProxySpace = settings.proxySettings.mirrorPositionProxySpace + Vector3.up * 0.001f;

var mirrorPosition = proxyToWorld.MultiplyPoint(mirrorPositionProxySpace);
var mirrorRotation = proxyToWorld.rotation * settings.proxySettings.mirrorRotationProxySpace * Quaternion.Euler(0, 180, 0);
var mirrorRotation = (proxyToWorld.rotation * settings.proxySettings.mirrorRotationProxySpace * Quaternion.Euler(0, 180, 0)).normalized;
var renderData = probe.renderData;

var gpuProj = GL.GetGPUProjectionMatrix(renderData.projectionMatrix, true);
Expand Down