Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
b9da5fa
Hd/fix 1299116 tesselation cull (#3057)
kecho Jan 14, 2021
5b57f64
Change the source value for the ray tracing frame index iterator from…
anisunity Jan 14, 2021
b21345b
[HDRP] Added a RenderGraph pass that resets the camera size after the…
alelievr Jan 14, 2021
9581f38
Fix Light Intensity UI Prefab Override Application (1299563) (#3061)
johnpars Jan 14, 2021
525ebf5
Fix Undo/Redo Stability for Light Temperature (1304176, 1301076) (#3079)
johnpars Jan 14, 2021
8007c48
Fix labels style (#3046)
adrien-de-tocqueville Jan 14, 2021
2df0185
Fixed side effect on styles during compositor rendering. (#3081)
adrien-de-tocqueville Jan 14, 2021
bf833ce
[HDRP][Compositor] Fix size and spacing of compositor info boxes (#3101)
pmavridis Jan 14, 2021
7be5e6c
[HDRP][Compositor] Fix color picker UI glitch in the Graphics Composi…
pmavridis Jan 14, 2021
6413dc6
Fix 1299233 ies resize bug (#3094)
skhiat Jan 14, 2021
8998567
filter for xbone addded (#3116)
martint-unity Jan 15, 2021
027cb37
[Yamato] Enable cache server for standalone build jobs (#3106)
sophiaaar Jan 15, 2021
6429445
Fix undo redo on layered lit editor (#3059)
adrien-de-tocqueville Jan 15, 2021
d910dc8
Merge branch 'master' into hd/bugfix
sebastienlagarde Jan 15, 2021
9c216c8
[HDRP] Added Vulkan install in system requirements (#3122)
alelievr Jan 15, 2021
8dbde86
[HDRP] Fix issue with compositor related custom passes (#3055)
pmavridis Jan 15, 2021
a5a6590
Fixed some render texture leaks. (#3050)
JulienIgnace-Unity Jan 15, 2021
229f3e8
Hd/fix wizard runtime resources (#3123)
RSlysz Jan 15, 2021
0a42f9b
[HDRP] Fixed lookdev reload bug when viewing a scene object (#3108)
alelievr Jan 15, 2021
eb1d074
[HDRP] Fix error in Depth Of Field near radius blur calculation (#3131)
pmavridis Jan 15, 2021
22b5b7f
[HDRP] Fix GC allocs (#3136)
pmavridis Jan 15, 2021
8cd8fe6
Revert: Fix 1299233 ies resize bug (#3094)
sebastienlagarde Jan 15, 2021
9bcb75f
Merge branch 'master' into hd/bugfix
sebastienlagarde Jan 16, 2021
31defd2
Merge branch 'master' into hd/bugfix
sebastienlagarde Jan 16, 2021
6dffbc8
Hide light shadow near plane gizmo when shadows are disabled (#3114)
adrien-de-tocqueville Jan 16, 2021
9ba9620
Hd/fix backplate globalcubemap2 (#3111)
JulienIgnace-Unity Jan 18, 2021
b4214a4
[HDRP][Path Tracing] Added alpha channel to path traced results (#3127)
eturquin Jan 18, 2021
feb0fe0
Doc update (#3160)
JulienIgnace-Unity Jan 18, 2021
d315646
Merge branch 'master' into hd/bugfix
sebastienlagarde Jan 18, 2021
f9c97c1
Fix various shader warnings (#3158)
FrancescoC-unity Jan 18, 2021
316d6a6
Update Override-Screen-Space-GI.md
sebastienlagarde Jan 18, 2021
be8f685
Fixed shadow matte not working with ambient occlusion when MSAA is en…
sebastienlagarde Jan 18, 2021
44ba81f
Merge branch 'master' into hd/bugfix
sebastienlagarde Jan 18, 2021
4de9b07
Update HDLightUI.cs (#3203)
sebastienlagarde Jan 20, 2021
1557004
[HDRP] fix nullref when chaging RP from HDRP to URP (#3191)
alelievr Jan 20, 2021
acd6199
fix case 1307653 (#3205)
sebastienlagarde Jan 20, 2021
f18d053
Merge branch 'master' into hd/bugfix
sebastienlagarde Jan 21, 2021
abd7de7
Fix LookDev env library assignment after leaving playmode. (#3214)
JulienIgnace-Unity Jan 21, 2021
6349ef2
Update Hair Shader Preset Documentation (#3208)
johnpars Jan 21, 2021
cace53e
[HDRP] Fix locale diffusion profile shader property value in ShaderGr…
alelievr Jan 21, 2021
760837b
Fix error in the RTHandle scale of Depth Of Field when TAA is enabled…
pmavridis Jan 21, 2021
3f480bd
Reset to current quality settings after preprocess build in HDRP (#3218)
jenniferd-unity Jan 21, 2021
4c7dfb6
Merge branch 'master' into hd/bugfix
sebastienlagarde Jan 21, 2021
3b4b1fb
Have bilinear default (#3223)
FrancescoC-unity Jan 21, 2021
a890c49
Merge branch 'master' into hd/bugfix
sebastienlagarde Feb 1, 2021
4477283
Update CHANGELOG.md
sebastienlagarde Feb 1, 2021
3112950
Added missing character to the layered lit document (#3310)
JordanL8 Feb 1, 2021
ac55059
Fix needs of exposure for debug display "SSR Transparent" (#3308)
skhiat Feb 1, 2021
bc0aa7d
[HDRP] Fix GUI exception in material UI (#3315)
alelievr Feb 1, 2021
c34ba38
[HDRP] Update decal angle fade tooltip (#3322)
alelievr Feb 1, 2021
1d8d12f
Fix uninitialized variable
adrien-de-tocqueville Feb 1, 2021
4e4e41b
Added comment
adrien-de-tocqueville Feb 1, 2021
525a974
Merge branch 'master' into urp/fix-shadow-split
adrien-de-tocqueville Feb 12, 2021
87ecbaf
Merge branch 'master' into urp/fix-shadow-split
sebastienlagarde Feb 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.universal/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed an issue in shaderGraph target where the ShaderPass.hlsl was being included after SHADERPASS was defined
- Fixed an issue where Particle Lit shader had an incorrect fallback shader [case 1312459]
- Fixed an issue with backbuffer MSAA on Vulkan desktop platforms.
- Fixed shadow cascade blend culling factor.

### Changed
- Change Asset/Create/Shader/Universal Render Pipeline/Lit Shader Graph to Asset/Create/Shader Graph/URP/Lit Shader Graph
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,7 @@ void RenderMainLightCascadeShadowmap(ref ScriptableRenderContext context, ref Cu

for (int cascadeIndex = 0; cascadeIndex < m_ShadowCasterCascadesCount; ++cascadeIndex)
{
//settings.splitData = m_CascadeSlices[cascadeIndex].splitData; // NOTE: currently DrawShadows culls more casters if no ShadowSplitData.cullingPlanes are set (version cds 8652678b), so it is currently better to not pass the m_CascadeSlices[cascadeIndex].splitData object returned by CullingResults.ComputeDirectionalShadowMatricesAndCullingPrimitives (change introduced in 8bf71cf). Culling is only based on the ShadowSplitData.cullingSphere distances.
var splitData = settings.splitData;
splitData.cullingSphere = m_CascadeSplitDistances[cascadeIndex];
settings.splitData = splitData;
settings.splitData = m_CascadeSlices[cascadeIndex].splitData;

Vector4 shadowBias = ShadowUtils.GetShadowBias(ref shadowLight, shadowLightIndex, ref shadowData, m_CascadeSlices[cascadeIndex].projectionMatrix, m_CascadeSlices[cascadeIndex].resolution);
ShadowUtils.SetupShadowCasterConstantBuffer(cmd, ref shadowLight, shadowBias);
Expand Down
4 changes: 4 additions & 0 deletions com.unity.render-pipelines.universal/Runtime/ShadowUtils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ public static bool ExtractDirectionalLightMatrix(ref CullingResults cullResults,
shadowSliceData.resolution = shadowResolution;
shadowSliceData.shadowTransform = GetShadowTransform(shadowSliceData.projectionMatrix, shadowSliceData.viewMatrix);

// This used to be fixed to .6f, but is now configureable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add to the comment that this is "culling sphere radius multiplier", so it's clear to the next reader. I had do a search to understand that as "cascade blend culling factor" seems like something "completely" different.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. Also in the end i changed the value to 0.6 because I think i makes more sense, since it was the original value

// It is the culling sphere radius multiplier for shadow cascade blending
shadowSliceData.splitData.shadowCascadeBlendCullingFactor = 0.6f;

// If we have shadow cascades baked into the atlas we bake cascade transform
// in each shadow matrix to save shader ALU and L/S
if (shadowData.mainLightShadowCascadesCount > 1)
Expand Down