Fix white flash on camera cuts with volumetric #3354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Feb 2, 2021
TomasKiniulis
suggested changes
Feb 3, 2021
There was a problem hiding this comment.
Hey @FrancescoC-unity! Please give a short description of what was tested and what additional testing is needed
Done! |
Thanks! |
TomasKiniulis
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Checked with @iM0ve since he already looked into the issue. Testing status is sufficient. Approving!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1270283/
The issue stems from the fact that the reprojection uses previous frame exposure, so not only we need to wait for reprojection data to be valid but also the previous exposure needs to be valid.
What did I test: The repro case both scrubbing and in play mode + I verified that reprojection still happens after the two frames we skip it (by checking in debugger :P )