Skip to content

[HDRP][PathTracing] Fixed dimensionality of a couple vectors (from 3 to 2). #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2021
Merged

[HDRP][PathTracing] Fixed dimensionality of a couple vectors (from 3 to 2). #3395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lines.high-definition/Runtime/Lighting/ScreenSpaceLighting/ScreenSpaceReflections.compute
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ bool SampleGGX_VNDF(float roughness_,

float VdotH;
float3 localV, localH;
SampleGGXVisibleNormal(inputSample, V, localToWorld, roughness, localV, localH, VdotH);
SampleGGXVisibleNormal(inputSample.xy, V, localToWorld, roughness, localV, localH, VdotH);

// Compute the reflection direction
float3 localL = 2.0 * VdotH * localH - localV;
Expand Down
4 changes: 2 additions & 2 deletions ...pipelines.high-definition/Runtime/RenderPipeline/PathTracing/Shaders/PathTracingBSDF.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ bool SampleAnisoGGX(MaterialData mtlData,
float VdotH;
float3 localV, localH;
float3x3 localToWorld = GetTangentFrame(mtlData);
SampleAnisoGGXVisibleNormal(inputSample, mtlData.V, localToWorld, roughnessX, roughnessY, localV, localH, VdotH);
SampleAnisoGGXVisibleNormal(inputSample.xy, mtlData.V, localToWorld, roughnessX, roughnessY, localV, localH, VdotH);

// Compute the reflection direction
float3 localL = 2.0 * VdotH * localH - localV;
Expand Down Expand Up @@ -336,7 +336,7 @@ bool SampleAnisoGGX(MaterialData mtlData,
float VdotH;
float3 localV, localH;
float3x3 localToWorld = GetTangentFrame(mtlData);
SampleAnisoGGXVisibleNormal(inputSample, mtlData.V, localToWorld, roughnessX, roughnessY, localV, localH, VdotH);
SampleAnisoGGXVisibleNormal(inputSample.xy, mtlData.V, localToWorld, roughnessX, roughnessY, localV, localH, VdotH);

// Compute refraction direction instead of reflection
float3 localL = refract(-localV, localH, 1.0 / mtlData.bsdfData.ior);
Expand Down
2 changes: 1 addition & 1 deletion ...pelines.high-definition/Runtime/RenderPipeline/PathTracing/Shaders/PathTracingVolume.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ void ComputeVolumeScattering(inout PathIntersection pathIntersection : SV_RayPay
// Light sampling
if (computeDirect)
{
if (SampleLights(lightList, inputSample.xyz, scatteringPosition, 0.0, ray.Direction, value, pdf, ray.TMax))
if (SampleLights(lightList, inputSample, scatteringPosition, 0.0, ray.Direction, value, pdf, ray.TMax))
{
// FIXME: Apply phase function and divide by pdf (only isotropic for now, and not sure about sigmaS value)
value *= _HeightFogBaseScattering.xyz * ComputeHeightFogMultiplier(scatteringPosition.y) * INV_FOUR_PI / pdf;
Expand Down