SRP-Picking changes #3419
Closed
SRP-Picking changes #3419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatible with gizmo picking.
… the selection outline buffer
… the selection outline buffer, HDRP implementation
com.unity.render-pipelines.high-definition/Runtime/Debug/MaterialDebug.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Material/Builtin/BuiltinData.hlsl
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Material/Builtin/BuiltinData.cs.hlsl
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Material/Builtin/BuiltinData.cs.hlsl
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Material/Builtin/BuiltinData.cs.hlsl
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Material/Builtin/BuiltinData.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Debug/MaterialDebug.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/RenderPass/AOV/AOVRequest.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/RenderPass/AOV/AOVRequest.cs
Outdated
Show resolved
Hide resolved
....render-pipelines.high-definition/Runtime/RenderPipeline/ShaderPass/ShaderPassDepthOnly.hlsl
Outdated
Show resolved
Hide resolved
jessebarker
reviewed
May 6, 2021
com.unity.render-pipelines.core/ShaderLibrary/DataExtraction.hlsl
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/ShaderLibrary/DataExtraction.hlsl
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Debug/DebugViewMaterialGBuffer.shader
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/RenderPass/AOV/AOVRequest.cs
Outdated
Show resolved
Hide resolved
| debug.SetFullScreenDebugMode(FullScreenDebugMode.WorldSpacePosition); | ||
| break; | ||
| case Camera.RenderRequestMode.BaseColor: | ||
| //@TODO: This should perform metallic / specular conversion |
There was a problem hiding this comment.
isn't this already done?
sebastienlagarde
suggested changes
May 25, 2021
...ty.render-pipelines.high-definition/Runtime/RenderPipeline/ShaderPass/ShaderPassForward.hlsl
Outdated
Show resolved
Hide resolved
# Conflicts: # com.unity.render-pipelines.core/ShaderLibrary/CommonMaterial.hlsl # com.unity.render-pipelines.core/ShaderLibrary/SpaceTransforms.hlsl # com.unity.render-pipelines.high-definition/Editor/Material/Decal/ShaderGraph/DecalSubTarget.cs # com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs # com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs.hlsl # com.unity.render-pipelines.high-definition/Runtime/Material/LayeredLit/LayeredLitTessellation.shader # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/ShaderPass/ShaderPassForward.hlsl # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/ShaderPass/ShaderPassForwardUnlit.hlsl # com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/PickingSpaceTransforms.hlsl
com.unity.render-pipelines.high-definition/Runtime/Debug/DebugViewMaterialGBuffer.shader
Outdated
Show resolved
Hide resolved
…traction.hlsl, they were removed from CommonMaterial.hlsl
…a value different from the clear value.
# Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/DebugViewMaterialGBuffer.shader # com.unity.render-pipelines.high-definition/Runtime/VFXGraph/Shaders/VFXLitPixelOutput.hlsl
phi-lira
suggested changes
Aug 24, 2021
# Conflicts: # com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/PickingSpaceTransforms.hlsl
…o incorrect backface culling.
|
replace by this PR: #5732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.