Skip to content

Conversation

PaulDemeulenaere
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere commented Feb 10, 2021

Purpose of this PR

Three minor fixes from #3414

  • VFXComponentTest.cs / CreateComponentWithAllBasicTypeExposed : Remove VFXValueType.CameraBuffer from the list of tested exposed type (it can't directly be exposed anyway)
  • VFXSlot.cs / Space_Slot_Sanitize_Still_Possible_ArcSphere : Unconsistent debug assert (the recreate can be called on subslot)
  • 31_CameraBuffer.png : Wrong image reference in player d3d11
    image

Testing status

Locally (but I didn't run everything)
Awaiting for Yamato ⏳

- Wrong Image reference : Fix D3D11 standalone
- Unconsistent debug assert (the recreate can be called on subslot) : Fix Space_Slot_Sanitize_Still_Possible_ArcSphere
- CreateComponentWithAllBasicTypeExposed : remove VFXValueType.CameraBuffer from list of tested exposed type (it can'td irectly be exposed)
These change can independantly land in `master`
Copy link
Contributor

@gabrieldelacruz gabrieldelacruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PaulDemeulenaere PaulDemeulenaere marked this pull request as ready for review February 10, 2021 15:25
@PaulDemeulenaere PaulDemeulenaere merged commit 6294867 into master Feb 10, 2021
@PaulDemeulenaere PaulDemeulenaere deleted the vfx/fix/1213482-camera-buffers-2-public-fix-test branch February 10, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants