Enable 119 test on Android Vulkan #3565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phi-lira
approved these changes
Feb 19, 2021
|
Removing needs backport because this one does not reproduce on newer samsung devices. Once we add them to 10.x this test will be enabled back with them, as I go through all tests (filtered and unfiltered) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR enables 119 test on Android vulkan as it was previously disabled due to instability.
I have reenabled it and ran couple of times the tests - no failures. I suspect maybe it was happening due to big load, which was lowered when projects were split. In any case, keeping test filtered out and a bug with huge user pain reported makes little sense to me. With PR I will be closing 1252270 ticket and opening a Jira ticket in Mobile Graphics team to log this incident.
Testing status
Yamato branch
Couple of tests on Yamato to try to reproduce, no failures so far.