Decal in material debug display #3608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-de-tocqueville
requested review from
remi-chapelain and
sebastienlagarde
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Feb 23, 2021
|
Added @JulienIgnace-Unity for RG check |
JulienIgnace-Unity
approved these changes
Feb 23, 2021
remi-chapelain
approved these changes
Feb 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
fix for https://fogbugz.unity3d.com/f/cases/1316568/
This PR fix the material debug display for decals (for normal, albedo, ...) on transparent/opaque objects and in forward/deferred by binding the decal buffers to the shaders
This requires computing the gpu light list during debug display for decals on transparent objects
It also fixes a wrong label on decal projector mask opacity channel under smoothness (which was labelled normal opacity channel)
And it also fixes the mask opacity option on normal when decal only affects normal (the mask opacity slider wasn't taken into account for the global fade factor computation)
Testing status
tested the repro steps of the fogbug