Skip to content

[HDRP][Compositor] Fixed issue with compositor custom pass hooks added/removed repeatedly #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2021
Merged

[HDRP][Compositor] Fixed issue with compositor custom pass hooks added/removed repeatedly #3613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ed3c22
Fixed issue with compositor custom pass hooks added/removed repeatedly
pmavridis Feb 23, 2021
4183cfa
Merge branch 'hd/bugfix' into HDRP/compositor_hooks
sebastienlagarde Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed error when increasing the maximum planar reflection limit (case 1306530).
- Fixed alpha output in debug view and AOVs when using shadow matte (case 1311830).
- Fixed an issue with transparent meshes writing their depths and recursive rendering (case 1314409).
- Fixed issue with compositor custom pass hooks added/removed repeatedly (case 1315971).

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
6 changes: 5 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Compositor/CompositionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ public bool enableOutput
{
if (m_OutputCamera)
{
// If the state did not change, don't do anything
if (m_OutputCamera.enabled == value)
return;

m_OutputCamera.enabled = value;

// Aside from the output compositor camera, we also have to change the cameras of the layers
Expand Down Expand Up @@ -496,7 +500,7 @@ public void UpdateLayerSetup()
void Update()
{
// TODO: move all validation calls to onValidate. Before doing it, this needs some extra testing to ensure nothing breaks
if (ValidatePipeline() == false || ValidateAndFixRuntime() == false || RuntimeCheck() == false)
if (enableOutput == false || ValidatePipeline() == false || ValidateAndFixRuntime() == false || RuntimeCheck() == false)
{
return;
}
Expand Down