Fixing ordering of UI Frame settings [Fogbugz 1315452] #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring enums that are tagged as obsolete.
kecho
force-pushed
the
hdrp/frame-settings-ordering-fix-1315452
branch
from
b89f5e1 to
13d36e6
Compare
victorsclui
reviewed
Feb 24, 2021
There was a problem hiding this comment.
It looks good and is very complete since we also make sure FrameSettingsFieldAttribute have the correct displayedName field.
Besides the comment about static dictionary reuse, since we are adding a static constructor, this sharing from the DOTS team may be of interest (https://unity.slack.com/archives/CE7DZN2H1/p1592525582345000).
...der-pipelines.high-definition/Editor/RenderPipeline/Settings/OverridableFrameSettingsArea.cs
Outdated
Show resolved
Hide resolved
victorsclui
approved these changes
Feb 24, 2021
sebastienlagarde
approved these changes
Feb 24, 2021
|
Please add a changelog |
|
Changelog added |
kecho
force-pushed
the
hdrp/frame-settings-ordering-fix-1315452
branch
from
ecaee73 to
855a977
Compare
remi-chapelain
approved these changes
Feb 25, 2021
sebastienlagarde
deleted the
hdrp/frame-settings-ordering-fix-1315452
branch
Merged
sebastienlagarde
added
backported-10.x
and removed
needs-backport-10.x
needs-backport-2021.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1315452/
Fixing order of settings in the UI. Orders were a bit messed on on the attribute. This attribute is safe to modify since its entirely used for UI purposes.
Testing status
Checked ordering is as expected, and enum Refraction isn't hidden anymore.