Skip to content

[XPipeline]Fix crash on VolumeComponentWithQualityEditor when the current Pipeline is not HDRP #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2021
Merged

[XPipeline]Fix crash on VolumeComponentWithQualityEditor when the current Pipeline is not HDRP #3643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
232ac82
[XPipeline]Fix crash on VolumeComponentWithQualityEditor when the cur…
alex-vazquez-unity3d Feb 24, 2021
0670d09
Changelog
alex-vazquez-unity3d Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed issue with compositor custom pass hooks added/removed repeatedly (case 1315971).
- Fixed: SSR with transparent (case 1311088)
- Fixed decals in material debug display.
- Fix crash on VolumeComponentWithQualityEditor when the current Pipeline is not HDRP

- Fixed WouldFitInAtlas that would previously return wrong results if any one face of a point light would fit (it used to return true even though the light in entirety wouldn't fit).

Expand Down
3 changes: 1 addition & 2 deletions ...ender-pipelines.high-definition/Editor/RenderPipeline/VolumeComponentWithQualityEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,7 @@ public override void OnEnable()

// Ensure we reflect presets in the pipeline asset, not the hardcoded defaults.
// Warning: base.OnEnable must be called after VolumeComponentWithQuality has unpacked SerializedData.
var pipeline = (HDRenderPipeline)RenderPipelineManager.currentPipeline;
if (pipeline != null)
if (RenderPipelineManager.currentPipeline is HDRenderPipeline pipeline)
{
serializedObject.Update();

Expand Down