[8.x.x][Shader Graph]Fixes for 3 cases of undo not working #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alindmanUnity
changed the title
alindmanUnity
changed the title
ghost
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Backport #259
Fixes bugs related to lack of registering undos: 1 prio 3 bug and 3 other Undo related bugs (first two are basically the same bug):
Internal link to previous PR
Manually Tested:
Manual Tests were repeated for backport branch
That none of the bug reproduces anymore
For the default-value-sub-node, all sorts of changes to confirm that the title asterisk only appears when necessary, such as something that results in the field returning to it was before type (0, safeaef => 0)
Technical Risk: 1/4
Halo Effect: 1/4