Skip to content

Fix SSGI frame setting not greyed out while SSGI is disabled in HDRP Asset #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Fix SSGI frame setting not greyed out while SSGI is disabled in HDRP Asset #3693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f35eac
Fix SSGI frame setting not greyed out while SSGI is disabled in HDRP …
victorsclui Mar 1, 2021
de50aab
Update CHANGELOG.md
victorsclui Mar 1, 2021
9af9741
Merge branch 'hd/bugfix' into hd/fix-ssgi-frame-setting-not-greyed-ou…
sebastienlagarde Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed ability to override AlphaToMask FrameSetting while camera in deferred lit shader mode
- Fixed issue with physically-based DoF computation and transparent materials with depth-writes ON.
- Fixed issue of accessing default frame setting stored in current HDRPAsset instead fo the default HDRPAsset
- Fixed SSGI frame setting not greyed out while SSGI is disabled in HDRP Asset

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
1 change: 1 addition & 0 deletions ...ender-pipelines.high-definition/Editor/RenderPipeline/Settings/FrameSettingsUI.Drawers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ static void Drawer_SectionLightingSettings(SerializedFrameSettings serialized, E
area.AmmendInfo(FrameSettingsField.SSR, overrideable: () => hdrpSettings.supportSSR);
area.AmmendInfo(FrameSettingsField.TransparentSSR, overrideable: () => (hdrpSettings.supportSSR && hdrpSettings.supportSSRTransparent));
area.AmmendInfo(FrameSettingsField.SSAO, overrideable: () => hdrpSettings.supportSSAO);
area.AmmendInfo(FrameSettingsField.SSGI, overrideable: () => hdrpSettings.supportSSGI);
area.AmmendInfo(FrameSettingsField.VolumetricClouds, overrideable: () => hdrpSettings.supportVolumetricClouds);

// SSS
Expand Down