Hd/fix access current hdrp asset for default frame settings 1317968 #3695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set instead fo the default HDRPAsset
sebastienlagarde
approved these changes
Mar 1, 2021
…fault-frame-settings-1317968
|
@qa: merging to move it in the pacakge, small change. Added QA for awareness |
sebastienlagarde
deleted the
hd/fix-access-current-hdrp-asset-for-default-frame-settings-1317968
branch
Merged
sebastienlagarde
added
backported-2021.1
backported-10.x
and removed
needs-backport-2021.1
needs-backport-10.x
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1317968/
Until we stored HDRP default setting in a separate scriptableObject, Default frame setting lives only inside the default HDRPAsset. So GetDefaultFrameSettingsFor should be calling HDRenderPipelineAsset hdrpAsset = HDRenderPipeline.defaultAsset; instead of HDRenderPipelineAsset hdrpAsset = GetHDRPAssetFor(owner);.
Testing status
Checked now camera Override Frame Setting is reading from the default Frame Setting from the default HDRP Asset instead of the current one now.