Skip to content

Avoid unnecessary RenderGraphBuilder.ReadTexture in the "Set Final Target" pass. #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Avoid unnecessary RenderGraphBuilder.ReadTexture in the "Set Final Target" pass. #3707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc60c1d
Avoid unnecessary RenderGraphBuilder.ReadTexture (and some trivial da…
victorsclui Mar 1, 2021
36eda4e
Update CHANGELOG.md
victorsclui Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Display a warning help box when decal atlas is out of size.
- Moved the HDRP render graph debug panel content to the Rendering debug panel.
- Changed Path Tracing's maximum intensity from clamped (0 to 100) to positive value (case 1310514).
- Avoid unnecessary RenderGraphBuilder.ReadTexture in the "Set Final Target" pass

## [11.0.0] - 2020-10-21

Expand Down
10 changes: 7 additions & 3 deletions ...y.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,11 +411,15 @@ void SetFinalTarget(RenderGraph renderGraph, HDCamera hdCamera, TextureHandle de
passData.copyDepth = passData.copyDepth || hdCamera.isMainGameView; // Specific case of Debug.DrawLine and Debug.Ray
#endif
passData.copyDepth = passData.copyDepth && !hdCamera.xr.enabled;
passData.copyDepthMaterial = m_CopyDepth;
passData.finalTarget = builder.WriteTexture(finalTarget);
passData.finalViewport = hdCamera.finalViewport;
passData.depthBuffer = builder.ReadTexture(depthBuffer);
passData.flipY = hdCamera.isMainGameView;

if (passData.copyDepth)
{
passData.depthBuffer = builder.ReadTexture(depthBuffer);
passData.flipY = hdCamera.isMainGameView;
passData.copyDepthMaterial = m_CopyDepth;
}

builder.SetRenderFunc(
(SetFinalTargetPassData data, RenderGraphContext ctx) =>
Expand Down