Skip to content

[HDRP] Backport fix custom pass prerefraction 2021.1 #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2021
Merged

[HDRP] Backport fix custom pass prerefraction 2021.1 #3877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef31dcf
Fixed wrong color buffer bound to pre refraction cusomt passes
alelievr Mar 12, 2021
203a190
Updated changelog
alelievr Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed HDRP material being constantly dirty.
- Fixed issue in path tracing, where objects would cast shadows even if not present in the path traced layers (case 1318857).
- Fixed SRP batcher not compatible with Decal (case 1311586)
- Fixed wrong color buffer being bound to pre refraction custom passes.

### Changed
- Removed the material pass probe volumes evaluation mode.
Expand Down
4 changes: 2 additions & 2 deletions ...y.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,9 +944,9 @@ TextureHandle RenderTransparency(RenderGraph renderGraph,

// TODO RENDERGRAPH: Remove this when we properly convert custom passes to full render graph with explicit color buffer reads.
// To allow users to fetch the current color buffer, we temporarily bind the camera color buffer
SetGlobalColorForCustomPass(renderGraph, currentColorPyramid);

SetGlobalColorForCustomPass(renderGraph, colorBuffer);
RenderCustomPass(m_RenderGraph, hdCamera, colorBuffer, prepassOutput, customPassCullingResults, cullingResults, CustomPassInjectionPoint.BeforePreRefraction, aovRequest, aovCustomPassBuffers);
SetGlobalColorForCustomPass(renderGraph, currentColorPyramid);

// Render pre-refraction objects
RenderForwardTransparent(renderGraph, hdCamera, colorBuffer, normalBuffer, prepassOutput, vtFeedbackBuffer, volumetricLighting, ssrLightingBuffer, null, lightLists, shadowResult, cullingResults, true);
Expand Down