Skip to content

Dirtying an asset that was upgraded to a new Version #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Dirtying an asset that was upgraded to a new Version #3964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa9ab06
Dirtying an asset that was upgraded to a new Version
jenniferd-unity Mar 23, 2021
234306c
Updated changelog
jenniferd-unity Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed preview camera updating the skybox material triggering GI baking (case 1314361/1314373).
- The default LookDev volume profile is now copied and referened in the Asset folder instead of the package folder.
- Fixed SSS on console platforms.
- Assets going through the migration system are now dirtied.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
12 changes: 9 additions & 3 deletions com.unity.render-pipelines.high-definition/Runtime/Core/Migration/MigrationDescription.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,16 @@ public bool Migrate(TTarget target)
}

#if UNITY_EDITOR
// Special in prefab case
if (target is UnityEngine.Object && UnityEditor.PrefabUtility.IsPartOfNonAssetPrefabInstance(target as UnityEngine.Object))
UnityEngine.Object targetObject = target as UnityEngine.Object;
if (targetObject != null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should never happens but yes better check this. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, the code was already checking for it and i was on the safe side :)

{
UnityEditor.PrefabUtility.RecordPrefabInstancePropertyModifications(target as UnityEngine.Object);
// Special in prefab case
if (UnityEditor.PrefabUtility.IsPartOfNonAssetPrefabInstance(targetObject))
{
UnityEditor.PrefabUtility.RecordPrefabInstancePropertyModifications(targetObject);
}

UnityEditor.EditorUtility.SetDirty(targetObject);
}
#endif
return true;
Expand Down