Skip to content

[HDRP] bugfixes scene selection pass in SG, StackLit debug specular color mod #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2021
Merged

[HDRP] bugfixes scene selection pass in SG, StackLit debug specular color mod #3985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c05c104
Fix scene selection pass for shadergraphs
slunity Mar 24, 2021
55f2b2f
Fix StackLit debug surfaceData specular color modification when in me…
slunity Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion com.unity.render-pipelines.high-definition/Editor/Material/ShaderGraph/HDTarget.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,6 @@ public static class Uniforms
public static RenderStateCollection SceneSelection = new RenderStateCollection
{
{ RenderState.Cull(Cull.Off) },
{ RenderState.ColorMask("ColorMask 0") },
};

public static RenderStateCollection DepthOnly = new RenderStateCollection
Expand Down
4 changes: 2 additions & 2 deletions com.unity.render-pipelines.high-definition/Runtime/Material/StackLit/StackLit.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,10 +911,10 @@ void GetSurfaceDataDebug(uint paramId, SurfaceData surfaceData, inout float3 res
}
case DEBUGVIEW_STACKLIT_SURFACEDATA_SPECULAR_COLOR:
{
if (!HasFlag(surfaceData.materialFeatures, DEBUGVIEW_STACKLIT_SURFACEDATA_SPECULAR_COLOR))
if (!HasFlag(surfaceData.materialFeatures, MATERIALFEATUREFLAGS_STACK_LIT_SPECULAR_COLOR))
{
// Derive the specular/fresnel0 term from the metallic parameter
result = ComputeFresnel0(surfaceData.baseColor, surfaceData.metallic.x, DEFAULT_SPECULAR_VALUE);
result = ComputeFresnel0(surfaceData.baseColor, surfaceData.metallic.x, IorToFresnel0(surfaceData.dielectricIor));
}
break;
}
Expand Down