Skip to content

Adding HDRP Global Settings Asset and saving HDRP Asset to new version #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2021
Merged

Adding HDRP Global Settings Asset and saving HDRP Asset to new version #3995

merged 2 commits into from
Mar 26, 2021

Conversation

jenniferd-unity
Copy link
Contributor

@jenniferd-unity jenniferd-unity commented Mar 25, 2021 •
edited
Loading

Purpose of this PR

SRP Smoke Test failing because HDRP Global Settings are not saved.
see Slack convo for details

Testing status

Tested locally + Yamato

@jenniferd-unity jenniferd-unity marked this pull request as ready for review March 25, 2021 10:05
theopnv
theopnv approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@theopnv theopnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting job is failing on master as well, it was fixed by another PR yesterday. So good to merge!

@sebastienlagarde sebastienlagarde merged commit 105988e into master Mar 26, 2021
@sebastienlagarde sebastienlagarde deleted the fix-srp-smoke-test-hd-global-settings branch March 26, 2021 07:45
@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Mar 26, 2021
Merged
sebastienlagarde added a commit that referenced this pull request Mar 31, 2021
@sebastienlagarde
Revert "Adding HDRP Global Settings Asset and saving HDRP Asset to ne…
b67c48f 
…w version (#3995)"

This reverts commit 105988e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastienlagarde sebastienlagarde Awaiting requested review from sebastienlagarde

1 more reviewer

@theopnv theopnv theopnv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

SRP testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jenniferd-unity @theopnv @sebastienlagarde