Skip to content

SceneObjectIDMap: Fix a nasty bug where game object to entry index dictionary would get out of sync from the entries list #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2021
Merged

SceneObjectIDMap: Fix a nasty bug where game object to entry index dictionary would get out of sync from the entries list #4038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cce3692
SceneObjectIDMap: Fix a nasty bug where gameobject to entry index dic…
pastasfuture Mar 29, 2021
67b1b8f
Update CHANGELOG.md
sebastienlagarde Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed SSS materials in planar reflections (case 1319027).
- Fixed Decal's pivot edit mode 2D slider gizmo not supporting multi-edition
- Fixed issue were the final image is inverted in the Y axis. Occurred only on final Player (non-dev for any platform) that use Dynamic Resolution Scaling with Contrast Adaptive Sharpening filter.
- Fixed a bug with Reflection Probe baking would result in an incorrect baking reusing other's Reflection Probe baking

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
5 changes: 5 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Utilities/SceneObjectIDMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,11 @@ int Insert<TCategory>(GameObject gameObject, TCategory category)

m_IndexByGameObject.Add(gameObject, index);
m_Entries.Insert(index, entry);
for (int i = index + 1; i < m_Entries.Count; ++i)
{
// Upon insertion, all index by game object entries after the insertion point need their index updated.
m_IndexByGameObject[m_Entries[i].gameObject] = i;
}
return m_Entries[index].id;
}

Expand Down