Skip to content

Conversation

Nzollner
Copy link
Contributor

…roject

Guide : https://github.com/Unity-Technologies/Graphics/blob/pr-template-correction/.github/pr-read.png.md

Display Addon : https://userstyles.org/styles/182991/unity-graphics-pr-readme

Purpose of this PR

This is a backport from: Unity-Technologies/ScriptableRenderPipeline#5972

Why is this PR needed, what hard problem is it solving/fixing?
The purpose of this PR is to take all URPs into consideration when checking for supported features instead of a singe URP.

Testing status

Manual Tests

What have you tested?
I have tested if there are no unintentional stripping of shader variants.
This is check to looking at the visuals and checking of the shader cache is the expected size.

Automated Tests

What did you setup? (Add a screenshot or the reference image of the test please)

Links

Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects or documents to go with this to help reviewers?

Comments to reviewers

Notes for the reviewers you have assigned.

@Nzollner Nzollner requested a review from phi-lira May 11, 2020 14:37
@Nzollner Nzollner requested a review from a team as a code owner May 11, 2020 14:37
@ellioman ellioman changed the title Added backport to handle all shader features for every RP active in p… [7.x.x Backport] Added backport to handle all shader features for every RP active in p… May 14, 2020
@phi-lira
Copy link
Contributor

Dont' need to rerun ABV. merge just changed changelog.md

@phi-lira phi-lira merged commit 7b8cf8e into 7.x.x/release May 27, 2020
@phi-lira phi-lira deleted the 7.x.x/bugfix/backport/1229945 branch May 27, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants