Skip to content

[Fogbugz 1328904] Fixing strange lanczos filter artifacts caused by too low epsilon #4165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2021
Merged

[Fogbugz 1328904] Fixing strange lanczos filter artifacts caused by too low epsilon #4165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
293dd08
Less aggressive epsilon, causing lines visual artifacts on ps4
kecho Apr 13, 2021
c2f9e0e
Changelog
kecho Apr 13, 2021
ef65cc0
Merge branch 'hd/bugfix' into HDRP/better-lanczos-epsilon
sebastienlagarde Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a NaN generating in Area light code.
- Fix potential NaN on apply distortion pass.
- Fixed the camera controller in the template with the old input system (case 1326816).
- Fixed broken Lanczos filter artifacts on ps4, caused by a very aggressive epsilon (case 1328904)

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/PostProcessing/Shaders/RTUpscale.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void WeightedAcc(CTYPE value, float weight, inout CTYPE accumulated, inout float
// TODO: Revisit derivation.
CTYPE Lanczos(TEXTURE2D_X(_InputTexture), float2 inUV, float2 textureSize)
{
const float epsilon = 0.0000000001;
const float epsilon = 1e-6;
const float a = 3.0; // Lanczos 3

float2 TexSize = textureSize.xy;
Expand Down