-
Notifications
You must be signed in to change notification settings - Fork 855
Hdrp: Move packing and dots instancing code to right location #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yamato is green for the code move (the red part are due to different issue). |
Code changes look good to me, I didn't find the Hybrid CI in Yamato so I queued that to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll quickly test this locally as well to make sure there are no problems with ObjectToWorld. I remember there were some problems when this code was originally written, which is why the macros were originally in a weird place in the code.
Thanks, The ObjectToWorld was not working due to the macro definition that I have now move to after the include of instancing. you can find the Yamato for Hybrid here: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Fupm-ci-abv.yml%2523all_project_ci_nightly_2020.1/2167305/job/pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I get some errors in local testing, and this Yamato job seems to have failed as well: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Fmove-code-to-right-location/.yamato%252Fupm-ci-hdrp_hybrid.yml%2523All_HDRP_Hybrid_2020.1/2175942/job
The error message I get locally is this: Shader error in 'Shader Graphs/RGBShader3': undeclared identifier 'unity_DOTSInstancing_F64_Metadata_Use_Macro_UNITY_MATRIX_M_instead_of_unity_ObjectToWorld' 'LoadDOTSInstancedData_float4x4': no matching 1 parameter function at /Coding/Graphics/com.unity.render-pipelines.core/ShaderLibrary/SpaceTransforms.hlsl(7) (on d3d11)
This suggests that the changed code does not interact well with the DOTS instancing macros. I will start investigating this immediately.
…_MACRO versions to avoid problems with other macros.
…d for Hybrid V2 to clean up code and reduce corner cases.
Replace by this PR: #442 |
Purpose of this PR
This PR is just moving code to their "correct" location.
Testing status
Manual Tests
Automated Tests
Links
Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
Comments to reviewers