Fix NaN cause when a 0-length normal is generated and then normalized. #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoC-unity
requested review from
a team
and removed request for
alindmanUnity
|
Closing to being based on master. |
sebastienlagarde
deleted the
HDRP/fix-0-length-normal-from-shadergraph
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug that it fixes is this: https://fogbugz.unity3d.com/f/cases/1243282/
The problem derives when shadergraph can generate a 0-length normal (for several manipulation that are possible, this is not impossible). This leads to a normalization that causes a div by 0, hence NaN ensue in lighting calculations.
I will backport when approved as I think there is a conflict that doesn't allow a simple cherry pick.
For QA:
Note that to repro you need to add a camera additional data to the camera and move around a bit when in play mode. Before this fix a small flash will happen.
Ping me and I can point to you where is a good spot to see the issue.