Skip to content

[HDRP] Add missing very high quality shadow component #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021
Merged

[HDRP] Add missing very high quality shadow component #4485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightUI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ static HDLightUI()
CED.AdditionalPropertiesFoldoutGroup(s_Styles.shadowMapSubHeader, Expandable.ShadowMap, k_ExpandedState, AdditionalProperties.Shadow, k_AdditionalPropertiesState,
DrawShadowMapContent, DrawShadowMapAdditionalContent, FoldoutOption.SubFoldout | FoldoutOption.Indent | FoldoutOption.NoSpaceAtEnd)),
CED.space,
CED.Conditional((serialized, owner) => k_AdditionalPropertiesState[AdditionalProperties.Shadow] && HasShadowQualitySettingsUI(HDShadowFilteringQuality.VeryHigh, serialized, owner),
CED.FoldoutGroup(s_Styles.veryHighShadowQualitySubHeader, Expandable.ShadowQuality, k_ExpandedState, FoldoutOption.SubFoldout | FoldoutOption.Indent, DrawVeryHighShadowSettingsContent)),
CED.Conditional((serialized, owner) => k_AdditionalPropertiesState[AdditionalProperties.Shadow] && HasShadowQualitySettingsUI(HDShadowFilteringQuality.High, serialized, owner),
CED.FoldoutGroup(s_Styles.highShadowQualitySubHeader, Expandable.ShadowQuality, k_ExpandedState, FoldoutOption.SubFoldout | FoldoutOption.Indent, DrawHighShadowSettingsContent)),
CED.Conditional((serialized, owner) => HasShadowQualitySettingsUI(HDShadowFilteringQuality.Medium, serialized, owner),
Expand Down Expand Up @@ -1339,9 +1341,8 @@ static void DrawHighShadowSettingsContent(SerializedHDLight serialized, Editor o

static void DrawVeryHighShadowSettingsContent(SerializedHDLight serialized, Editor owner)
{
EditorGUILayout.PropertyField(serialized.kernelSize, s_Styles.kernelSize);
EditorGUILayout.PropertyField(serialized.lightAngle, s_Styles.lightAngle);
EditorGUILayout.PropertyField(serialized.maxDepthBias, s_Styles.maxDepthBias);
// Same as high for now (PCSS)
DrawHighShadowSettingsContent(serialized, owner);
}

static void SetLightsDirty(Editor owner)
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2377,7 +2377,7 @@ void SetCommonShadowRequestSettings(HDShadowRequest shadowRequest, VisibleLight
// This base bias is a good value if we expose a [0..1] since values within [0..5] are empirically shown to be sensible for the slope-scale bias with the width of our PCF.
float baseBias = 5.0f;
// If we are PCSS, the blur radius can be quite big, hence we need to tweak up the slope bias
if (filteringQuality == HDShadowFilteringQuality.High)
if (filteringQuality == HDShadowFilteringQuality.High || filteringQuality == HDShadowFilteringQuality.VeryHigh)
{
if (softness > 0.01f)
{
Expand Down
4 changes: 4 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,10 @@ public static DirectionalShadowAlgorithm GetDirectionalShadowAlgorithm()
{
return DirectionalShadowAlgorithm.PCSS;
}
case HDShadowFilteringQuality.VeryHigh:
{
return DirectionalShadowAlgorithm.PCSS;
}
}
;
return DirectionalShadowAlgorithm.PCF5x5;
Expand Down
3 changes: 3 additions & 0 deletions ...nity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadowManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,9 @@ void InitializeScreenSpaceShadows()
case HDShadowFilteringQuality.High:
s_ScreenSpaceShadowsMat.EnableKeyword("SHADOW_HIGH");
break;
case HDShadowFilteringQuality.VeryHigh:
s_ScreenSpaceShadowsMat.EnableKeyword("SHADOW_VERY_HIGH");
break;
default:
s_ScreenSpaceShadowsMat.EnableKeyword("SHADOW_MEDIUM");
break;
Expand Down