[9.x.x] Remove player-connection-ip argument from UTP command line arguments #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stramit
approved these changes
May 15, 2020
|
android is green and yamato queue is high today, so i'm going to cancel the remaining jobs and merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes recent failures where test run is simply canceled. Some changes happened to the image and now we dont need the ip of device. Moreover, it started to fail the tests, so removing it fixes the issues.
Testing status
Manual Tests
none, changes are done only to bokken job
Automated Tests
Ran yamato tests
Links
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/android%252Ffix-recent-failures