Skip to content

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Jul 22, 2021

Purpose of this PR

New decal projector had an epsilon that was too high. This would cause decals to snap like in a grid when updating.
2021-07-21_14-44-16


Testing status

  • Manual local, moved a decal slowly and ensured its updated

@kecho kecho requested a review from sebastienlagarde July 22, 2021 14:24
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Jul 22, 2021
@sebastienlagarde sebastienlagarde marked this pull request as ready for review July 22, 2021 14:30
@sebastienlagarde sebastienlagarde merged commit 9fa7bef into master Jul 22, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/FixingEpsilonOnDecalProjectors branch July 22, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants