Improved the ray tracing fallback mechanic (case 1350590). #5303

anisunity · 2021-08-05T10:05:20Z

https://fogbugz.unity3d.com/f/cases/1350590/
Added a control for the fallback for the last bounce (rtgi/rtr/rr) to keep a previously existing side effect on user demand (case 1350590).

Fixed an inconsistance between perf mode and quality mode for sky lighting (case 1350590).
Fixed an inconsistance between perf quand quality mode for material simplification in rtgi (case 1350590).
This PR adds a lot of tests to significantly increase the coverage.

Testing status
Tests have been updated and are all green locally.

…to keep a previously existing side effect on user demand (case 1350590). - Fixed an inconsistance between perf mode and quality mode for sky lighting (case 1350590). - Fixed an inconsistance between perf quand quality mode for material simplification in rtgi (case 1350590).

github-actions · 2021-08-05T10:06:17Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

iM0ve

Whats tested:

Used the new parameters to see if they function as expected
Upgraded 2 projects to see that the result with default values is unchanged (except bug fix)
Verified that SSGI, SSR and Recursive rendering is still working properly

Minor concerns:

FIXED Naming of the new properties does not match exactly on all overrides
FIXED Tooltip is missing for Recursive Rendering
https://user-images.githubusercontent.com/36502659/128500397-317611df-96e5-4757-8233-8f792aae3de6.mp4

Demo:

bPJYHOCYwB.mp4

iM0ve

Verified the latest fixes and quickly tested properties still work

Vic-Cooper

Docs reviewed, please check for accuracy.

Vic-Cooper · 2021-08-10T14:13:08Z

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -81,6 +81,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Added warning for when a light is not fitting in the cached shadow atlas and added option to set maximum resolution that would fit.
 - Added a custom post process injection point AfterPostProcessBlurs executing after depth of field and motion blur.
 - Added the support of volumetric clouds for baked and realtime reflection probes.
+- Added a control for the fallback for the last bounce (rtgi/rtr/rr) to keep a previously existing side effect on user demand (case 1350590).


Added a property to control the fallback of the last bounce of a RTGI, RTR, RR ray to keep a previously existing side effect on user demand (case 1350590).

Vic-Cooper · 2021-08-10T14:14:25Z

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -355,6 +356,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed the camera near plane not being taken into account when rendering the clouds (case 1353548).
 - Fixed controls for clouds fade in (case 1353548).
 - Reduced the number shader variants for the volumetric clouds.
+- Fixed an inconsistance between perf mode and quality mode for sky lighting (case 1350590).


Typo: inconsistance > inconsistency :D

Fixed an inconsistency between perf mode and quality mode for sky lighting (case 1350590).

Vic-Cooper · 2021-08-10T14:16:26Z

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -355,6 +356,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed the camera near plane not being taken into account when rendering the clouds (case 1353548).
 - Fixed controls for clouds fade in (case 1353548).
 - Reduced the number shader variants for the volumetric clouds.
+- Fixed an inconsistance between perf mode and quality mode for sky lighting (case 1350590).
+- Fixed an inconsistance between perf quand quality mode for material simplification in rtgi (case 1350590).


Typos, also caps acronyms:

Fixed an inconsistency between perf mode and quality mode for material simplification in RTGI (case 1350590).

Vic-Cooper · 2021-08-10T14:43:43Z

com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md

@@ -46,13 +46,16 @@ HDRP uses the [Volume](Volumes.md) framework to calculate SSGI, so to enable and
 | - **Denoiser Radius**          | Set the radius of the spatio-temporal filter.                |
 | - **Second Denoiser Pass**     | Enable this feature to process a second denoiser pass. This helps to remove noise from the effect. |
 | **Depth Tolerance** | Use the slider to control the tolerance when comparing the depth of the GameObjects on screen and the depth buffer. Because the SSR algorithm can not distinguish thin GameObjects from thick ones, this property helps trace rays behind GameObjects. The algorithm applies this property to every GameObject uniformly. |
+| **Ray Miss**         | Defines if HDRP should use the reflection probes, the sky, both or nothing as a fall-back for screen space global illumination when a ray doesn't find an intersection. |


Determines what HDRP does when a screen space global illumination (SSGI) ray doesn't find an intersection. Choose from one of the following options:
• Reflection probes: HDRP uses reflection probes in your scene to calculate the missing SSGI intersection.
• Sky: HDRP uses the sky defined by the current Volume settings to calculate the missing SSGI intersection.
• Both: HDRP uses both reflection probes and the sky defined by the current Volume settings to calculate the missing SSGI intersection.
• Nothing: HDRP does not calculate indirect lighting when SSGI doesn't find an intersection.

This property is set to Both by default.

Vic-Cooper · 2021-08-11T13:33:57Z

com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md


 ### Ray-traced

 ![](Images/Override-ScreenSpaceGlobalIllumination2.png)

 | Property                       | Description                                                  |
 | ------------------------------ | ------------------------------------------------------------ |
+| **Ray Miss**                   | Defines if HDRP should use the reflection probes, the sky, both or nothing as a fall-back for ray-traced global illumination when a ray doesn't find an intersection. |


Determines what HDRP does when ray-traced global illumination (RTGI) doesn't find an intersection. . Choose from one of the following options:
• Reflection probes: HDRP uses reflection probes in your scene to calculate the last RTGI bounce.
• Sky: HDRP uses the sky defined by the current Volume settings to calculate the last SSGI bounce.
• Both : HDRP uses both reflection probes and the sky defined by the current Volume settings to calculate the last SSGI bounce.
• Nothing: HDRP does not calculate indirect lighting when RTGI doesn't find an intersection.

This property is set to Both by default

Vic-Cooper · 2021-08-11T13:35:15Z

com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md


 ### Ray-traced

 ![](Images/Override-ScreenSpaceGlobalIllumination2.png)

 | Property                       | Description                                                  |
 | ------------------------------ | ------------------------------------------------------------ |
+| **Ray Miss**                   | Defines if HDRP should use the reflection probes, the sky, both or nothing as a fall-back for ray-traced global illumination when a ray doesn't find an intersection. |
+| **Last Bounce**                | Defines if HDRP should use the reflection probes, the sky, both or nothing as a fall-back for ray-traced global illumination when lighting the last bounce. |


Determines what HDRP does when ray-traced global illumination (RTGI) lights the last bounce. Choose from one of the following options:
• Reflection probes: HDRP uses reflection probes in your scene to calculate the last RTGI bounce.
•Sky:** HDRP uses the sky defined by the current Volume settings to calculate the last RTGI bounce.
• Both : HDRP uses both reflection probes and the sky defined by the current Volume settings to calculate the last RTGI bounce.
• Nothing: HDRP does not calculate indirect lighting when it evaluates the last bounce.

This property is set to Both by default.

anisunity · 2021-08-11T15:52:48Z

Just pushed the docs updates

Vic-Cooper

SSGI > RTGI typos.

Vic-Cooper · 2021-08-11T15:57:22Z

com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md


 ### Ray-traced

 ![](Images/Override-ScreenSpaceGlobalIllumination2.png)

 | Property                       | Description                                                  |
 | ------------------------------ | ------------------------------------------------------------ |
+| **Ray Miss**                   | Determines what HDRP does when ray-traced global illumination (RTGI) doesn't find an intersection. Choose from one of the following options: <br/>&#8226;**Reflection probes**: HDRP uses reflection probes in your scene to calculate the last RTGI bounce.<br/>&#8226;**Sky**: HDRP uses the sky defined by the current [Volume](Volumes.md) settings to calculate the last SSGI bounce.<br/>&#8226;**Both** : HDRP uses both reflection probes and the  the sky defined by the current [Volume](Volumes.md) settings to calculate the last SSGI bounce.<br/>&#8226;**Nothing**: HDRP does not calculate indirect lighting when RTGI doesn't find an intersection.<br/><br/>This property is set to **Both** by default|


SSGI should be RTGI here, apologies for missing that!:

Determines what HDRP does when ray-traced global illumination (RTGI) doesn't find an intersection. Choose from one of the following options:
•Reflection probes: HDRP uses reflection probes in your scene to calculate the last RTGI bounce.
•Sky: HDRP uses the sky defined by the current Volume settings to calculate the last RTGI bounce.
•Both : HDRP uses both reflection probes and the the sky defined by the current Volume settings to calculate the last RTGI bounce.
•Nothing: HDRP does not calculate indirect lighting when RTGI doesn't find an intersection.

This property is set to Both by default

Vic-Cooper

Small changes in ray-tracing-recursive-rendering.

Vic-Cooper · 2021-08-11T16:16:59Z

com.unity.render-pipelines.high-definition/Documentation~/Ray-Tracing-Recursive-Rendering.md

@@ -29,7 +29,7 @@ You can also do this for Shader Graph master nodes:
 1. In the Project window, double-click on the Shader to open it in Shader Graph.
 2. In the **Graph Settings** tab of the **Graph Inspector**, go to **Surface Options** and enable **Recursive Rendering (Preview)**.

-It is best practice to use recursive rendering in situations that require multi-bounced reflection and refraction, for example car headlights. Although recursive rendering also produces ray-traced reflections in more simple scenarios, like for a mirror or a puddle, it is best practice to use [ray-traced reflections](Ray-Traced-Reflections.md) here for performance reasons.
+It is best practice to use recursive rendering in situations that require multi-bounced reflection and refraction, for example car headlights. Although recursive rendering also produces recursive rendering in more simple scenarios, like for a mirror or a puddle, it is best practice to use [ray-traced reflections](Ray-Traced-Reflections.md) here for performance reasons.


Let's improve the phrasing here:

It is best practice to use recursive rendering in situations that require multi-bounced reflection and refraction, for example, car headlights. You can use recursive rendering in simple scenarios, like a mirror or a puddle, but for best performance, use ray-traced reflections.

not sure when i changed this, probably a find and replace

Vic-Cooper · 2021-08-11T16:18:46Z

com.unity.render-pipelines.high-definition/Documentation~/Ray-Tracing-Recursive-Rendering.md

@@ -41,3 +41,5 @@ Since recursive rendering uses an independent render pass, HDRP cannot render an
 | **Max Depth**  | Controls the maximum number of times a ray can reflect or refract before it stops and returns the final color. Increasing this value increases execution time exponentially. |
 | **Max Ray Length** | Controls the length of the rays that HDRP uses for ray tracing. If a ray doesn't find an intersection, then the ray returns the color of the sky. |
 | **Min Smoothness** | Defines the threshold at which reflection rays are not cast if the smoothness value of the target surface is inferior to the one defined by the parameter. |
+| **Ray Miss**                  | Determines what HDRP does when recursive rendering (RR) doesn't find an intersection. Choose from one of the following options: <br/>&#8226;**Reflection probes**: HDRP uses reflection probes in your scene to calculate the last RR bounce.<br/>&#8226;**Sky**: HDRP uses the sky defined by the current [Volume](Volumes.md) settings to calculate the last RR bounce.<br/>&#8226;**Both** : HDRP uses both reflection probes and the  the sky defined by the current [Volume](Volumes.md) settings to calculate the last RR bounce.<br/>&#8226;**Nothing**: HDRP does not calculate indirect lighting when RR doesn't find an intersection.<br/><br/>This property is set to **Both** by default|


I don't think we need to abbreviate recursive rendering to RR here (also fixed double "the" typo):

| Ray Miss | Determines what HDRP does when recursive rendering doesn't find an intersection. Choose from one of the following options:
•Reflection probes: HDRP uses reflection probes in your scene to calculate the last recursive rendering bounce.
•Sky: HDRP uses the sky defined by the current Volume settings to calculate the last recursive rendering bounce.
•Both : HDRP uses both reflection probes and the sky defined by the current Volume settings to calculate the last recursive rendering bounce.
•Nothing: HDRP does not calculate indirect lighting when recursive rendering doesn't find an intersection.

This property is set to Both by default|

Vic-Cooper · 2021-08-11T16:20:09Z

com.unity.render-pipelines.high-definition/Documentation~/Ray-Tracing-Recursive-Rendering.md

@@ -41,3 +41,5 @@ Since recursive rendering uses an independent render pass, HDRP cannot render an
 | **Max Depth**  | Controls the maximum number of times a ray can reflect or refract before it stops and returns the final color. Increasing this value increases execution time exponentially. |
 | **Max Ray Length** | Controls the length of the rays that HDRP uses for ray tracing. If a ray doesn't find an intersection, then the ray returns the color of the sky. |
 | **Min Smoothness** | Defines the threshold at which reflection rays are not cast if the smoothness value of the target surface is inferior to the one defined by the parameter. |
+| **Ray Miss**                  | Determines what HDRP does when recursive rendering (RR) doesn't find an intersection. Choose from one of the following options: <br/>&#8226;**Reflection probes**: HDRP uses reflection probes in your scene to calculate the last RR bounce.<br/>&#8226;**Sky**: HDRP uses the sky defined by the current [Volume](Volumes.md) settings to calculate the last RR bounce.<br/>&#8226;**Both** : HDRP uses both reflection probes and the  the sky defined by the current [Volume](Volumes.md) settings to calculate the last RR bounce.<br/>&#8226;**Nothing**: HDRP does not calculate indirect lighting when RR doesn't find an intersection.<br/><br/>This property is set to **Both** by default|
+| **Last Bounce**               | Determines what HDRP does when recursive rendering (RR) lights the last bounce. Choose from one of the following options: <br/>&#8226;**Reflection probes**: HDRP uses reflection probes in your scene to calculate the last RR bounce.<br/>&#8226;**Sky**: HDRP uses the sky defined by the current [Volume](Volumes.md) settings to calculate the last RR bounce.<br/>&#8226;**Both**:  HDRP uses both reflection probes and the sky defined by the current [Volume](Volumes.md) settings to calculate the last RR bounce.<br/>&#8226;**Nothing**: HDRP does not calculate indirect lighting when it evaluates the last bounce.<br/><br/>This property is set to **Both** by default. |


As above:

| Last Bounce | Determines what HDRP does when recursive rendering lights the last bounce. Choose from one of the following options:
•Reflection probes: HDRP uses reflection probes in your scene to calculate the last bounce.
•Sky: HDRP uses the sky defined by the current Volume settings to calculate the last recursive rendering bounce.
•Both: HDRP uses both reflection probes and the sky defined by the current Volume settings to calculate the last recursive rendering bounce.
•Nothing: HDRP does not calculate indirect lighting when it evaluates the last bounce.

This property is set to Both by default. |

Vic-Cooper

Docs done, thanks!

anisunity added 4 commits August 5, 2021 11:55

Update tests

f9a18f5

Update documentation

12e31a7

Formatting

0a42c74

anisunity added HDRP dxr labels Aug 5, 2021

anisunity requested review from a team, iM0ve and sebastienlagarde August 5, 2021 10:05

anisunity self-assigned this Aug 5, 2021

github-actions bot added the testing label Aug 5, 2021

Missing section for rr

02011c8

anisunity marked this pull request as ready for review August 5, 2021 10:11

iM0ve requested changes Aug 6, 2021

View reviewed changes

Review corrections and adapt scenes

0b814e6

anisunity requested a review from iM0ve August 9, 2021 07:46

iM0ve approved these changes Aug 9, 2021

View reviewed changes

anisunity requested review from JulienIgnace-Unity and Vic-Cooper August 9, 2021 08:49

Update doc

4646fe2

JulienIgnace-Unity approved these changes Aug 10, 2021

View reviewed changes

Vic-Cooper requested changes Aug 11, 2021

View reviewed changes

Update doc

f340427

anisunity requested a review from Vic-Cooper August 11, 2021 15:52

Vic-Cooper requested changes Aug 11, 2021

View reviewed changes

Fix doc again

6ab31c3

Vic-Cooper requested changes Aug 11, 2021

View reviewed changes

review fixes

8ec067b

anisunity requested a review from Vic-Cooper August 11, 2021 16:39

Vic-Cooper approved these changes Aug 12, 2021

View reviewed changes

anisunity and others added 2 commits August 12, 2021 13:41

Merge branch 'master' into HDRP/fix-1350590

f302f83

Fix formatting

971f22b

JulienIgnace-Unity merged commit ad9a961 into master Aug 12, 2021

JulienIgnace-Unity deleted the HDRP/fix-1350590 branch August 12, 2021 12:20

Improved the ray tracing fallback mechanic (case 1350590). #5303

Improved the ray tracing fallback mechanic (case 1350590). #5303

Uh oh!

Conversation

anisunity commented Aug 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 5, 2021

Uh oh!

iM0ve left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iM0ve left a comment

Choose a reason for hiding this comment

Uh oh!

Vic-Cooper left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vic-Cooper Aug 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vic-Cooper Aug 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vic-Cooper Aug 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anisunity commented Aug 11, 2021

Uh oh!

Vic-Cooper left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vic-Cooper left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vic-Cooper left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anisunity commented Aug 5, 2021 •

edited

Loading

iM0ve left a comment •

edited

Loading

Vic-Cooper Aug 10, 2021 •

edited

Loading

Vic-Cooper Aug 11, 2021 •

edited

Loading

Vic-Cooper Aug 11, 2021 •

edited

Loading