Skip to content

Conversation

alex-vazquez
Copy link
Contributor


Purpose of this PR

Fixing the magic margin of the additional properties

URP Asset:

image

HDRP Light inspector
image

Volume Editor 1 level additional properties

image

Volume Editor 2 level of additional properties

image


Testing status

Test URP asset, HDRP light inspector and Volume Component Editors


Comments to reviewers

I've put the description of the problem in the comment in the code :) We are generating a new GUIStyle everytime, but I think is not a big problem

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde deleted the x-pipeline/additional-properties-magic-margin branch September 1, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants