Skip to content

Conversation

anisunity
Copy link
Contributor

https://fogbugz.unity3d.com/f/cases/1353955/
The volumetric clouds require a sun to work, previously a fallback sun was created, vertical and had an intensity of 1 (pre-exposed). Users prefer to have a black sun, let's do that.

Testing status
Checked that it works, trivial enough
sunBlack

@anisunity anisunity self-assigned this Aug 16, 2021
@anisunity anisunity marked this pull request as ready for review August 16, 2021 09:08
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Aug 16, 2021
@remi-chapelain remi-chapelain requested a review from a team August 16, 2021 09:09
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense and is more inline with what users expect when there's no sun. ✔️

@anisunity anisunity merged commit 7b9c3a3 into master Aug 16, 2021
@anisunity anisunity deleted the HDRP/fix-1353955 branch August 16, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants