Skip to content

Conversation

sarah-welton
Copy link
Contributor

File should now be found in the documentation.

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [x ] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Solving an error where the Triangle-Wave-Node file was not showing up in the documentation, due to a typo in the file name.

File should now be found in the documentation.
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Unity SRP repo!
Please make sure to fill out the PR template as best you can to give reviewers as much information as possible.
If you have any questions (and you are a Unity employee) go to "#devs-renderpipe"

@sarah-welton sarah-welton added ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV and removed ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV labels Aug 16, 2021
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarah-welton sarah-welton merged commit dbd1758 into master Aug 16, 2021
@sarah-welton sarah-welton deleted the sg-doc-fix-1350872 branch August 16, 2021 19:34
@sarah-welton sarah-welton restored the sg-doc-fix-1350872 branch August 16, 2021 20:04
@sarah-welton sarah-welton deleted the sg-doc-fix-1350872 branch August 16, 2021 21:10
sarah-welton added a commit that referenced this pull request Aug 16, 2021
File for Triangle-Wave-Node should now be found in the documentation.
sarah-welton added a commit that referenced this pull request Aug 16, 2021
File for Triangle-Wave-Node should now be found in the documentation.
sarah-welton added a commit that referenced this pull request Aug 18, 2021
…#5386)

File for Triangle-Wave-Node should now be found in the documentation.
sarah-welton added a commit that referenced this pull request Aug 18, 2021
…#5386)

File for Triangle-Wave-Node should now be found in the documentation.
marctem pushed a commit that referenced this pull request Aug 19, 2021
File for Triangle-Wave-Node should now be found in the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants