Use SafeNormalize for normals sampled from XYZ (non-DXT5nm/ASTCnm) no… #5356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix case 1351020
Testing status
Manual
Comments to reviewers
With 3 component normal maps it's easily possible to get near-zero-length normals after filtering.
Combined with normalization in fp16 this can cause sporadic Inf/NaN which then spreads with post processing effects like Bloom when rendering to a floating point framebuffer.
With DXT5nm this cannot happen because the decoding always makes sure that the length is 1.
It would probably be possible to sanitize normals during import but this is much easier and XYZ normal maps are legacy anyway.