Removed DLSS keyword from settings' search (case 1358409) #5361
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
| { | ||
| static class RenderPipelineSettingsUtilities | ||
| { | ||
| public static IEnumerable<string> Case1358409Workaround(IEnumerable<string> keywords) |
There was a problem hiding this comment.
Do we really need a name like this? I guess there is no other way to do that right? So it's not really necessary to reference a bug case IMO.
So having something explicit like "RemoveDLSSKeywordIfNeeded" would be fine by me.
There was a problem hiding this comment.
As discussed offline, I'll wait for Julien to decide the naming
There was a problem hiding this comment.
While this solution is not "generic", sadly, as discussed with @fredericv-unity3d , we cannot do something more elegant that would include future hidden properties too.
This still fixes the issue though ✔️
# Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md
* Removed DLSS keyword from settings' search (case 1358409) * Changed naming * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
4 participants
Purpose of this PR
Fixes case 1358409
Removed DLSS keyword in settings search to prevent pinging hidden DLSS properties when the NVIDIA package is not installed.
Testing status
Manual testing:
Comments to reviewers