Skip to content

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Aug 17, 2021

Purpose of this PR

Fixed compilation problems on preview shader when using hybrid renderer v2 and property desc override Hybrid Per Instance.


Testing status

Tested by following repro steps from fogbugz:

https://fogbugz.unity3d.com/f/cases/1358506/

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

… per instancing on properties.

Removing ifdef guards for hybrid renderer v1
@kecho kecho force-pushed the HDRP/FixShaderPreviewGraphHybridInstancing branch from 76524ea to 4ec9a14 Compare August 17, 2021 16:14
@kecho kecho requested a review from a team August 23, 2021 13:33
@kecho kecho marked this pull request as ready for review August 23, 2021 13:33
@kecho kecho requested a review from a team as a code owner August 23, 2021 13:33
Copy link
Contributor

@iM0ve iM0ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, testing the repro case should be enough

Copy link

@cdxntchou cdxntchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sebastienlagarde sebastienlagarde merged commit a067c55 into master Aug 24, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/FixShaderPreviewGraphHybridInstancing branch August 24, 2021 17:04
sebastienlagarde pushed a commit that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants