-
Notifications
You must be signed in to change notification settings - Fork 855
[Fogbugz 1358506] Fixing shader graph codegen of preview shader hybrid v2, using hybrid… #5370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fogbugz 1358506] Fixing shader graph codegen of preview shader hybrid v2, using hybrid… #5370
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. Shader Graph Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
… per instancing on properties. Removing ifdef guards for hybrid renderer v1
76524ea
to
4ec9a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, testing the repro case should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…d v2, using hybrid… #5370
Purpose of this PR
Fixed compilation problems on preview shader when using hybrid renderer v2 and property desc override Hybrid Per Instance.
Testing status
Tested by following repro steps from fogbugz:
https://fogbugz.unity3d.com/f/cases/1358506/