Skip to content

Conversation

julienf-unity
Copy link
Contributor

@julienf-unity julienf-unity commented Aug 17, 2021

Purpose of this PR

Various fixes:

This is a backport of #5371


Testing status

Tested locally


Comments to reviewers

This PR is meant to be backported to partner branch.
It is high priority

@julienf-unity julienf-unity requested review from a team and PaulDemeulenaere August 17, 2021 15:44
@github-actions github-actions bot added the vfx label Aug 17, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@VladNeykov VladNeykov requested review from VladNeykov and removed request for a team August 17, 2021 16:30
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change than #5371 (review) 🟢

Copy link
Contributor

@VladNeykov VladNeykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on slack, one of the cases (1355820) still reproduces, and the FTP project has a change of behavior due to the World to Local fixes.

Otherwise, no issues found. @julienf-unity please let me know how you'd like to proceed (if the change of behavior is expected and the order of transformations should be fixed here or removed from the changelog and addressed later)

Test doc

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked this change 86083d4 🟢

Copy link
Contributor

@VladNeykov VladNeykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, no outstanding issues pertaining to this PR (test doc). Thanks for the fix!

@julienf-unity julienf-unity merged commit 0b6b83c into 10.x.x/release Sep 9, 2021
@julienf-unity julienf-unity deleted the 10.x.x/vfx/fix/importer-and-compil-fixes branch September 9, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants