Skip to content

Conversation

bencloward
Copy link
Contributor

The Sclera Iris Blend node had the same name as the Sclera Limbal Ring node, so when you selected the Sclera Iris Blend node from the Create Node menu, the Sclera Limbal Ring node was added instead. This made it impossible to add a Sclera Iris Blend node to the graph.

Purpose of this PR

Fixed the name field of the Sclera Iris Blend node so that it can be added to a graph via the Create Node menu.


Testing status

After making this change, I was able to add the node correctly in my local branch.


Comments to reviewers

Notes for the reviewers you have assigned.

The Sclera Iris Blend node had the same name as the Sclera Limbal Ring node, so when you selected the Sclera Iris Blend node from the Create Node menu, the Sclera Limbal Ring node was added instead.  This made it impossible to add a Sclera Iris Blend node to the graph.
@bencloward bencloward requested review from a team and alelievr August 17, 2021 17:09
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Aug 17, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@bencloward bencloward requested review from anisunity and removed request for alelievr August 17, 2021 18:02
Copy link
Contributor

@anisunity anisunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bencloward bencloward merged commit ddb8f75 into master Aug 17, 2021
@bencloward bencloward deleted the sg-fixed-ScleraIrisBlend branch August 17, 2021 20:48
sebastienlagarde pushed a commit that referenced this pull request Aug 27, 2021
The Sclera Iris Blend node had the same name as the Sclera Limbal Ring node, so when you selected the Sclera Iris Blend node from the Create Node menu, the Sclera Limbal Ring node was added instead.  This made it impossible to add a Sclera Iris Blend node to the graph.
sebastienlagarde added a commit that referenced this pull request Aug 29, 2021
* Merge Hd/bugfix #5255

* Merge Hd/bugfix #5306

* Fixed Bug That Prevented Sclera Iris Blend node from being added (#5375)

The Sclera Iris Blend node had the same name as the Sclera Limbal Ring node, so when you selected the Sclera Iris Blend node from the Create Node menu, the Sclera Limbal Ring node was added instead.  This made it impossible to add a Sclera Iris Blend node to the graph.

* Merge Hd/bugfix #5427

* Fix compilation issue

* Update MotionVectorVertexShaderCommon.hlsl

Co-authored-by: bencloward <88061215+bencloward@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants