Skip to content

Conversation

emilybrown1
Copy link
Contributor

@emilybrown1 emilybrown1 commented Aug 18, 2021

In response to a Slack conversation: https://unity.slack.com/archives/G1BTWN88Z/p1628667454038200

Changed a sentence in the Limitations section to make it clear that the structure can store a reference to any structure apart from a 2D texture because it has to be blittable.

@github-actions github-actions bot added the vfx label Aug 18, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mathieum-unity
Copy link
Contributor

mathieum-unity commented Aug 19, 2021

Am I the right Mathieu to review this? Maybe this was meant for Mathieu Muller?

@emilybrown1 emilybrown1 removed the request for review from mathieum-unity August 24, 2021 07:56
@Matjioe
Copy link

Matjioe commented Aug 24, 2021

Approved! (Mathieu)

@julienf-unity julienf-unity merged commit ce6af81 into master Aug 24, 2021
@julienf-unity julienf-unity deleted the vfx/docs/graphicsBufferSupportforVFXGraph branch August 24, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants