Skip to content

Conversation

anisunity
Copy link
Contributor

https://fogbugz.unity3d.com/f/cases/1353727/
A new volume parameter "Full Resolution" was added to the ray marching based GI to be able to tune down the cost of the effect a very high rendering resolutions. The cost of the effect is approximately reduced by 4 when disabling the full resolution mode.
image

Testing status
Made sure the rendering looked correct in both full resolution and half resolution modes.

…solution to achieve real-time compatible performance in high resolutions (case 1353727).
@anisunity anisunity added the HDRP label Aug 18, 2021
@anisunity anisunity requested review from a team and JulienIgnace-Unity August 18, 2021 10:23
@anisunity anisunity self-assigned this Aug 18, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@anisunity
Copy link
Contributor Author

Found an issue in history buffer discarding, need to fix

@anisunity
Copy link
Contributor Author

Fixed some issues, still some related to the temporal reprojection

@anisunity
Copy link
Contributor Author

Fixed temporal reprojection issues

2021-08-18_23-20-15.mp4

@anisunity anisunity marked this pull request as ready for review August 18, 2021 22:40
@anisunity
Copy link
Contributor Author

DXR tests are green locally

Copy link
Contributor

@iM0ve iM0ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats tested:

  • Tested the half rez feature works both in SSGI Ray marching and mixed modes
  • Upgraded 2 projects to look for visual change
  • Based on files changed did a quick smoke test for some parameters of :
  • Raytraced SSGI
  • Raytraced SSAO
  • Raytraced SSS

Demo:
As expected before and after the PR there is no visual difference. When using the new feature, the image is different. When denoiser is disabled even easier to spot the resolution changes.

No SSGI
No SSGI

SSGI before PR
SSGI before PR

SSGI after PR
SSGI after PR

SSGI with reintroduced feature Full Resolution = false
SSGI half rez

No denoiser

7oCn870rNP.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants