-
Notifications
You must be signed in to change notification settings - Fork 855
X pipeline - When editing a light preset, the light type was disabled #5389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightUI.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightUI.cs
Outdated
Show resolved
Hide resolved
cb570e8
to
f91d0c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR integrates the flow of Presets as something permanent. I am worried about the impact of integrating a workaround as something not temporary (even if we aim to remove it and never know when it will land).
Any fields for Preset are supposed to be supported. The previous PR aims to rectify our UI to show that some fields are not properly supported without having to check the doc or file a bug because of a preset not being fully applied/working.
f91d0c7
to
8f4d4ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only unexpcted thing I noticed while testing this, is when you select area light in the light preset, it's not saved and it will default to point when de-selecting the preset.
71500713312d381723acba8d812cc148.mp4
36884ee
to
fb9b1e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue fixed ! All good ✔️
Purpose of this PR
The scope was handling a property from the additional camera data
Testing status
Check light presets save, apply and edit. Also check normal light inspector.
Comments to reviewers
@Unity-Technologies/gfx-qa-hdrp Test the preset edition of the lights, and the light inspector