Skip to content

Conversation

alex-vazquez
Copy link
Contributor

@alex-vazquez alex-vazquez commented Aug 18, 2021

Purpose of this PR

The scope was handling a property from the additional camera data


Testing status

Check light presets save, apply and edit. Also check normal light inspector.


Comments to reviewers

@Unity-Technologies/gfx-qa-hdrp Test the preset edition of the lights, and the light inspector

@github-actions
Copy link

github-actions bot commented Aug 18, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@alex-vazquez alex-vazquez force-pushed the x-pipeline/1358733-light-preset-fixes branch from cb570e8 to f91d0c7 Compare August 19, 2021 09:10
Copy link
Contributor

@jenniferd-unity jenniferd-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR integrates the flow of Presets as something permanent. I am worried about the impact of integrating a workaround as something not temporary (even if we aim to remove it and never know when it will land).
Any fields for Preset are supposed to be supported. The previous PR aims to rectify our UI to show that some fields are not properly supported without having to check the doc or file a bug because of a preset not being fully applied/working.

@alex-vazquez alex-vazquez force-pushed the x-pipeline/1358733-light-preset-fixes branch from f91d0c7 to 8f4d4ce Compare August 19, 2021 10:27
@alex-vazquez alex-vazquez changed the title X pipeline - Improvements and bug fixing on Preset Editors X pipeline - When editing a light preset, the light type was disabled Aug 19, 2021
@alex-vazquez alex-vazquez marked this pull request as ready for review August 26, 2021 09:18
@alex-vazquez alex-vazquez requested a review from a team August 26, 2021 09:18
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only unexpcted thing I noticed while testing this, is when you select area light in the light preset, it's not saved and it will default to point when de-selecting the preset.

71500713312d381723acba8d812cc148.mp4

@remi-chapelain remi-chapelain self-requested a review August 30, 2021 10:59
@alex-vazquez alex-vazquez force-pushed the x-pipeline/1358733-light-preset-fixes branch from 36884ee to fb9b1e0 Compare August 30, 2021 11:43
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue fixed ! All good ✔️

@alex-vazquez
Copy link
Contributor Author

image
Yamato is green despite the fact that the CI is not being updated on the PR.

@alex-vazquez alex-vazquez merged commit 31c75c6 into master Aug 31, 2021
@alex-vazquez alex-vazquez deleted the x-pipeline/1358733-light-preset-fixes branch August 31, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants