Skip to content

Conversation

alex-vazquez
Copy link
Contributor


Purpose of this PR

First step of light temperature slider unification

Splitting the Light Sliders on their own files + HD specific sliders start now with HD at the beggining.

Nothing has changed excep the TemperatureSliderUIDrawer.


Testing status

Check the slider works as expected


Comments to reviewers

First PR to help the refactor review.

@alex-vazquez alex-vazquez self-assigned this Aug 18, 2021
@alex-vazquez alex-vazquez changed the title X pipeline/improve light UI step1 X pipeline - Improve light UI step1 Aug 18, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@arttu-peltonen arttu-peltonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However in order for this PR to make sense, I think it's missing the removal of old code. Now if this PR lands there are duplicate implementations.

@alex-vazquez alex-vazquez force-pushed the x-pipeline/improve-light-ui-step1 branch from e87127f to c714e16 Compare August 19, 2021 08:50
@alex-vazquez alex-vazquez marked this pull request as ready for review August 19, 2021 13:49
@alex-vazquez alex-vazquez merged commit ff1cb8d into master Aug 19, 2021
@alex-vazquez alex-vazquez deleted the x-pipeline/improve-light-ui-step1 branch August 19, 2021 13:49
@github-actions github-actions bot added the HDRP label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants